Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation build and upgrade guide #52634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Description

This PR improves the documentation around building and upgrading the documentation site, based on recent experiences with the Docusaurus upgrade process. The changes include:

  • Detailed build verification steps and common issues
  • Framework upgrade guidelines
  • Improved broken link handling documentation
  • Build performance considerations

Type of Change

  • Documentation update

Link to Devin run

https://app.devin.ai/sessions/c0c18bdaabc246119ec3b36f8b67e751

Test Instructions

  1. Navigate to the /docusaurus directory
  2. Run pnpm install
  3. Run pnpm clear && pnpm build
  4. Verify the build completes successfully
  5. Run pnpm start and verify the development server works

Documentation

This PR is a documentation improvement.

- Add detailed build verification steps
- Document common build issues and solutions
- Add framework upgrade guidelines
- Improve broken link handling documentation

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Can you take a look at this and propose a plan? <https://github.com/airbytehq/airbyte/issues/52630>

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:05pm


1. **Broken Links and Anchors**
- Links must match the exact case of the target file/heading
- Anchors are generated from headings: spaces become hyphens, special characters are removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true, but it's also possible to specify anchors manually. This is important when creating headings you want to link to from other places, because it prevents anchor links from breaking if a heading is rewritten later.

3. **Build Performance**
- First builds may take longer due to dependency installation
- Use `pnpm clear` before `pnpm build` to ensure a clean build
- The development server (`pnpm start`) may take 1-2 minutes to initially compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place for this information. This section is about production builds, but this information talks about a development build.

- Use production builds to catch all link issues
- Fix the most critical navigation paths first
- Update internal cross-references systematically
- Consider adding redirects for moved content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify that this is done with the redirects.yaml file.

2. **Resolution Steps**
- Use production builds to catch all link issues
- Fix the most critical navigation paths first
- Update internal cross-references systematically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this?


3. **Prevention**
- Test links in both development and production builds
- Use relative paths for internal documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean: use relative paths when linking to content within the site. This is not internal documentation.

- Test links in both development and production builds
- Use relative paths for internal documentation
- Follow consistent heading case conventions
- Document any intentionally external references
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary. We can easily scan for these.

3. **Prevention**
- Test links in both development and production builds
- Use relative paths for internal documentation
- Follow consistent heading case conventions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. Firstly, this has nothing to do with preventing broken links. Secondly, follow the guidance in the Google Developers Style Guide, as this article already specifies.

- Note any custom components or plugins that might be affected

2. **During the Update**
- Update dependencies incrementally if possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, yeah this is good practice. But upgrading the core Docusaurus library and running pnpm install will update dependencies for you. You do not need to incrementally update anything with Docusaurus unless this is a complex, major, breaking change. This is incredibly rare and Docusaurus will issue guidance for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants