Update source-braintree to CDK 6.0+ and baseImage 4.0.0+ #55176
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerOriginal prompt from [email protected]: I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
octavia-squidington-iii
added
area/connectors
devin-ai-integration
bot
changed the title
|
/bump-version |
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
|
run poetry lock and push it up |
|
/bump-version type="minor"
|
| @@ -101,3 +101,4 @@ You've checked out the repo, implemented a million dollar feature, and you're re | |||
| 6. Pat yourself on the back for being an awesome contributor. | |||
| 7. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master. | |||
| 8. Once your PR is merged, the new version of the connector will be automatically published to Docker Hub and our connector registry. | |||
| # Dummy change to verify CI status | |||
There was a problem hiding this comment.
Remove this before we merge please
| @@ -1,5 +1,9 @@ | |||
| version: 0.50.0 | |||
| type: DeclarativeSource | |||
| concurrency_level: | |||
There was a problem hiding this comment.
Remove this change, we don't want concurrency level yet.
|
/bump-version type="minor"
|
octavia-squidington-iii
added
the
area/documentation
| args = sys.argv[1:] | ||
| catalog_path = None | ||
| config_path = None | ||
| state_path = None | ||
|
|
||
| for i in range(len(args) - 1): | ||
| if args[i] == "--catalog": | ||
| catalog_path = args[i + 1] | ||
| elif args[i] == "--config": | ||
| config_path = args[i + 1] | ||
| elif args[i] == "--state": | ||
| state_path = args[i + 1] | ||
|
|
||
| catalog = None | ||
| if catalog_path: | ||
| with open(catalog_path, "r") as f: | ||
| catalog = json.loads(f.read()) | ||
|
|
||
| config = None | ||
| if config_path: | ||
| with open(config_path, "r") as f: | ||
| config = json.loads(f.read()) | ||
|
|
||
| state = None | ||
| if state_path: | ||
| with open(state_path, "r") as f: | ||
| state = json.loads(f.read()) | ||
|
|
||
| source = SourceBraintree(catalog=catalog, config=config, state=state) | ||
| launch(source, args) |
There was a problem hiding this comment.
I think this section change is what causes a lot of acceptance tests to fail. Can you look into other source connectors that run on Airbyte CDK 6.0 and that are using CDK directly (not manifest-only) and see how they implement run and the source class?
This PR updates source-braintree to CDK 6.0+ and baseImage 4.0.0+.
Link to Devin run: https://app.devin.ai/sessions/f60b6c65288841fd979dfe772c9c89e8
Requested by: community-devs in Slack