🐛 Source Outreach: remove stream_state interpolation #55180
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyleromines is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
kyleromines
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
Oh that's funny. Your fix should NOT work, and the reason interpolated string stopped working is because we ripped out @pnilan can you post links to examples of replacing stream state with stream slices? |
|
Roughly look at this as an example: #54663 |
I can confirm that it does work after running local tests, but yes this felt hacky to me. |
natikgadzhi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In version 1.0.30 and before cursor_field is set to "updatedAt"
After 1.1.0 cursor_field is being set to InterpolatedString(string='updatedAt', default='updatedAt') causing this error when running a check: Unable to connect to stream accounts - unhashable type: 'InterpolatedString'
How
Pull string property from InterpolatedString class
Review guide
User Impact
Currently cannot set up source with latest version as the check fails and upgrading an existing source to the latest connector version causes syncs to fail with same error.
Can this PR be safely reverted and rolled back?