Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Teradata destination connector #55183

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sc250072
Copy link
Contributor

@sc250072 sc250072 commented Mar 4, 2025

What

  1. Upgraded Teradata JDBC driver to 20.00.00.43
  2. Added more unit tests to improve code quality
  3. Added jacoco module to generate code coverage

How

  1. Updated JDBC driver version in Teradata destination connector build.gradle
  2. Added new Test class TeradataSqlOperationsTest.java to improve code coverage and quality
  3. Added jacoco module in build.gradle

Review guide

  1. airbyte-integrations/connectors/destination-teradata/build.gradle
  2. airbyte-integrations/connectors/destination-teradata/src/main/java/io/airbyte/integrations/destination/teradata/TeradataSqlOperations.java
  3. airbyte-integrations/connectors/destination-teradata/src/test/java/io/airbyte/integrations/destination/teradata/TeradataSqlOperationsTest.java

User Impact

No Impact to End user

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Reports generated before raising PR

  1. Teradata internal Snyk to find for vulnerabilities. Report is clean.
    image

  2. Code coverage report. 81% is the code coverage number
    image

  3. Formatter success on Connector code
    image

  4. Unit tests and Integration tests success

@sc250072 sc250072 requested a review from a team as a code owner March 4, 2025 04:40
Copy link

vercel bot commented Mar 4, 2025

@sc250072 is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/teradata
Projects
Development

Successfully merging this pull request may close these issues.

2 participants