-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial H1 PWI decoding #138
base: master
Are you sure you want to change the base?
Conversation
I made this a draft to have a discussion regarding how we want to represent this data. There are 4 current decoreResult looks like
|
|
||
if (data.length === 3) { | ||
const tempData = data[2]; | ||
const tempFlightLevel = Number(tempData.slice(0, 3)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this usually matches flightLevel
, sometimes it does not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it isn't matching flight level, what is it? Or is that still a mystery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought i found a message that had the temp at a lower flight level, but now i can't find it
I agree with your assessment to normalize the data a bit, making the raw data much more specific and concrete as individual nested values, rather than a single string representation. The format looks good to me, I think you've done a good pass there. |
@fredclausen - adding you as a reviewer as Kevin and I can't decide how we want the formatted result to be for the wind reports. Each one separate? or shove them all (or some?) together? |
No description provided.