v2.0 ADC API doc changes #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #617
Added deprecation of is and not.
|
@bcorrie If we want to collect all doc changes for v2.0 in this PR, maybe we could move the changes to the ADC API spec files to another PR? This way we could merge them potentially sooner (as they seem uncontroversial to me) and avoid collisions when we try to merge this PR down the road... |
|
@bussec I originally created this to contain all doc changes, but realized there were enough ADC API doc changes. So this PR is for all of ADC API doc changes, I have changed the title to that effect. |
|
I plan on finishing the two remaining ADC API doc changes maybe today and then merging this. |
|
@bcorrie Ok, thanks for clarifying. PR looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617
Fixes #751
Fixes #528
Fixes #619
Fixes #487
Fixes #431