Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix read gzip, add test case #808

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lang/python/airr/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def read_rearrangement(filename, validate=False, debug=False):
airr.io.RearrangementReader: iterable reader class.
"""
if filename.endswith(".gz"):
handle = gzip.open(filename, 'r')
handle = gzip.open(filename, 'rt')
else:
handle = open(filename, 'r')

Expand Down
Binary file added lang/python/tests/data/good_rearrangement.tsv.gz
Binary file not shown.
19 changes: 19 additions & 0 deletions lang/python/tests/test_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def setUp(self):

# Test data
self.rearrangement_good = os.path.join(data_path, 'good_rearrangement.tsv')
self.rearrangement_good_gz = os.path.join(data_path, 'good_rearrangement.tsv.gz')
self.rearrangement_bad = os.path.join(data_path, 'bad_rearrangement.tsv')
self.rep_good = os.path.join(data_path, 'good_repertoire.yaml')
self.rep_bad = os.path.join(data_path, 'bad_repertoire.yaml')
Expand Down Expand Up @@ -59,6 +60,24 @@ def test_load_rearrangement(self):
result = airr.load_rearrangement(self.rearrangement_bad)
self.assertTupleEqual(result.shape, self.shape_bad, 'load(): bad data failed')

# @unittest.skip('-> read_rearrangement(): skipped\n')
def test_read_rearrangement(self):
# Good data
result = []
reader = airr.read_rearrangement(self.rearrangement_good)
for row in reader:
result.append(row)
reader.close()
self.assertTrue(len(result) == self.shape_good[0], 'read_rearrangement(): good data failed')

# Good data, gzip
result = []
reader = airr.read_rearrangement(self.rearrangement_good_gz)
for row in reader:
result.append(row)
reader.close()
self.assertTrue(len(result) == self.shape_good[0], 'read_rearrangement(): good data (gzip) failed')

# @unittest.skip('-> repertoire_template(): skipped\n')
def test_repertoire_template(self):
try:
Expand Down
Loading