-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #71
Update README.md #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @neeru24 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
@ajaynegi45 check it please Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @neeru24 !!
Your idea to showcase metrics is good and it looks very nice in the readme.
But Please consider placing that metrics table somewhere below contributors list i.e above the graph showing star history of Repo. And please consider keeping green color for Closed PR's number display.
Thank you 😄
Sure, I'll do the changes soon and submit a PR |
@Devamani11D done with the changes. Kindly merge it and assign me labels! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neeru24
It looks good.
Thank you for your contributions. 🚀
Please feel free to contribute furthur.
I have added metrices table in the readme.
Benefits:
Kindly assign me this issue and merge it @ajaynegi45
Thank you!!