fix: path consistency & some code improvements #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should fix and improve cross platform experience of the application without breaking compatibility with anything, but needs more testing so if anyone wants to try it out they are welcome
ajeetdsouza
force-pushed
the
main
branch
3 times, most recently
from
4a7505d
to
073500c
Compare
ajeetdsouza
force-pushed
the
main
branch
2 times, most recently
from
d72d9ce
to
cbb8e77
Compare
|
Sorry folks haven't kept up with the PR, life's been busy had to shift houses, then change jobs, then move again due to new job, and stuff. Will try to wrap this up this weekend(feel free to ping me at mail[at]swarnimarun[dot]com if I don't get it done within a couple weeks). |
Gentle reminder (please don't feel any pressure, this is FOSS after all) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
this should fix and improve the cross-platform experience of the application without breaking compatibility with anything, but it needs more testing. Hence, if anyone wants to try it out they are welcome.
the bug
The bug this pr should address(this is the bug on Windows I think the reason for the bug is obvious),
aside
Consider this to be complete, I will take a better look over the code on the weekend and move it out of the draft, ensure nothing is broken and fix(also add more) tests.
Note: I came across zoxide while looking into a False Positive report (I lead the Rust Analysis stuff(and a few other things) at DeepSource). Very interesting project, btw. Found some bugs while going through the code, so fixed them.