-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sky zoo #25
base: main
Are you sure you want to change the base?
feat: sky zoo #25
Conversation
return useQuery({ | ||
queryKey: ['sky-zoo', { did }], | ||
queryFn: async () => { | ||
const response = await fetch(`https://skyzoo.blue/stats/plc/${did}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jycouet i get CORS errors when running this in tests. is there any chance the headers could be a little less restrictive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are running test on what port ?
(I'm avoiding laptop until next Monday, but I'll do something)
Let me know ✌️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look, but don't manage to see the error test.
When I do npm run test
, I don't get dirrectly failed test, I need to check the report. I'm missing something ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any reason you're restricting the CORS at all? why not just set it to *
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit worried about over usage... But you are right, I'll open it!
It should be working now with *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is still not ok ? 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you seeing any requests on your end? its weird because this only fails in the tests. if i try it in my browser it's fine. 🤔
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at "https://skyzoo.blue/stats/plc/did:plc:k6acu4chiwkixvdedcmdgmal".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why is that in test env !
And don't manage to see "log" with "npm run test" I see the summary, but not live tests. It's a config issue ?
I'll look into it later 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may need to merge with the test skipped and revisit it. it works in the browser and thats what really matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
I let you do ✌️
Deploying akari with Cloudflare Pages
|
needed for #20