fix: concurrent provider certs validation #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
previously approved these changes
Jan 31, 2025
baktun14
previously approved these changes
Jan 31, 2025
stalniy
force-pushed
the
fix/concurent-cert-validation
branch
from
f345de0 to
742a841
Compare
stalniy
force-pushed
the
fix/concurent-cert-validation
branch
from
742a841 to
f377993
Compare
ygrishajev
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
when we have 2 concurrent requests 1 and 2,
#1goes intofinallyblock and removes Sema instance and then#2goes intofinallyblock and tries to release released Sema instance but that instance was removed by#1What
Checks whether lock exists in the hashmap of locks because it could be released and cleared by another validation request