Skip to content

Commit

Permalink
Respond to CRAN submission comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
akgold committed Jul 1, 2020
1 parent a2a2545 commit 7c57f5d
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 5 deletions.
2 changes: 2 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
^.*\.Rproj$
^\.Rproj\.user$
^LICENSE\.md$
^CRAN-RELEASE$
^cran-comments\.md$
2 changes: 2 additions & 0 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This package was submitted to CRAN on 2020-07-01.
Once it is accepted, delete this file and tag the release (commit a2a25457ae).
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
Package: stickr
Type: Package
Title: View and Use R Hex Stickers
Version: 0.3.0
Version: 0.3.1
Authors@R: person("Alex", "Gold", email = "[email protected]",
role = c("aut", "cre"))
Description: Download and use R hex stickers. Stickers made
available in standardized locations in GitHub repositories, as well as those in the
[`rstudio/hex-stickers`](github.com/rstudio/hex-stickers) repository will be available.
<https://github.com/rstudio/hex-stickers> repository will be available.
URL: https://github.com/akgold/stickr
License: MIT + file LICENSE
Encoding: UTF-8
Expand Down
9 changes: 6 additions & 3 deletions R/funs.R
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,13 @@ pkg_repo <- function(pkg) {
}

get_pkg_git <- function(pkg) {
if (!pkg %in% rownames(utils::installed.packages())) return(NULL)
desc <- tryCatch(utils::packageDescription(pkg),
warning = function(e) "Not Found")

txt <- unclass(utils::packageDescription(pkg))[c("url", "bugreports",
"URL", "BugReports")]
if (desc[1] == "Not Found") return(NULL)

txt <- unclass(desc)[c("url", "bugreports",
"URL", "BugReports")]
txt <- txt[!vapply(txt, is.null, logical(1))]
if (length(txt) == 0) return(NULL)

Expand Down
10 changes: 10 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Test environments
* local R installation, R 3.5.2
* ubuntu 16.04 (on travis-ci), R 3.5.2
* win-builder (devel)

## R CMD check results

0 errors | 0 warnings | 1 note

* This is a new release.

0 comments on commit 7c57f5d

Please sign in to comment.