feat(ui): allow to sort comment columns and show comment in tooltip o…

…n icon hover ref #1054
akiver · Jan 25, 2025 · 0dd7963 · 0dd7963
1 parent 1d2961a
commit 0dd7963
Show file tree

Hide file tree

Showing 14 changed files with 8 additions and 47 deletions.
diff --git a/src/node/video/hlae/get-hlae-version-from-executable.ts b/src/node/video/hlae/get-hlae-version-from-executable.ts
@@ -18,6 +18,7 @@ export async function getHlaeVersionFromExecutable(executablePath: string): Prom
   return new Promise((resolve, reject) => {
     const sanitizedExecutablePath = sanitizeExecutablePath(executablePath);
 
+    // TODO wmic is deprecated. https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmic
     exec(
       `wmic datafile where 'name="${sanitizedExecutablePath}"' get version`,
       { windowsHide: true },

diff --git a/src/ui/changelog/changelog-dialog.tsx b/src/ui/changelog/changelog-dialog.tsx
@@ -83,6 +83,10 @@ export function ChangelogDialog() {
                 <Category>DOWNLOAD</Category> Improved error message when retrieving last MM matches while your Steam
                 account is in-game on another device.
               </li>
+              <li>
+                <Category>UI</Category> Comment columns are now sortable, and the comment is displayed in a tooltip when
+                the icon is hovered over.
+              </li>
               <li>
                 <Category>VIDEO</Category> Allow to set seconds before/after each kill/round to start/stop sequences
                 through a dialog.

diff --git a/src/ui/components/matches/use-matches-columns.tsx b/src/ui/components/matches/use-matches-columns.tsx
@@ -39,7 +39,6 @@ export function useMatchesColumns() {
         width: 20,
         allowResize: false,
         allowMove: false,
-        allowSort: false,
       },
       {
         id: 'tags',

diff --git a/src/ui/components/table/cells/comment-cell.tsx b/src/ui/components/table/cells/comment-cell.tsx
@@ -1,8 +1,8 @@
 import React from 'react';
-import { Trans } from '@lingui/react/macro';
 import { CommentDotsIcon } from 'csdm/ui/icons/comment-dots-icon';
 import { Tooltip } from '../../tooltip';
 import type { CellProps } from '../table-types';
+import { MarkdownEditor } from '../../inputs/markdown-editor';
 
 type Props = CellProps<{ comment?: string }>;
 
@@ -13,13 +13,7 @@ export function CommentCell({ data }: Props) {
   }
 
   return (
-    <Tooltip
-      content={
-        <p>
-          <Trans context="Tooltip">Comment</Trans>
-        </p>
-      }
-    >
+    <Tooltip delay={0} content={<MarkdownEditor defaultValue={comment} />}>
       <CommentDotsIcon width={12} height={12} />
     </Tooltip>
   );

diff --git a/src/ui/components/table/table.tsx b/src/ui/components/table/table.tsx
@@ -50,7 +50,7 @@ export function Table<DataType extends Data>({ table }: Props<DataType>) {
                 }
 
                 return (
-                  <div className="px-4">
+                  <div className={column.allowResize ? 'px-4' : ''}>
                     {sortDirection === 'desc' ? <ArrowDownLongIcon height={16} /> : <ArrowUpLongIcon height={16} />}
                   </div>
                 );

diff --git a/src/ui/demos/table/use-demos-columns.ts b/src/ui/demos/table/use-demos-columns.ts
@@ -36,7 +36,6 @@ export function useDemosColumns() {
         }),
         Cell: CommentCell,
         allowResize: false,
-        allowSort: false,
         allowMove: false,
       },
       {

diff --git a/src/ui/players/table/use-players-columns.ts b/src/ui/players/table/use-players-columns.ts
@@ -36,7 +36,6 @@ export function usePlayersColumns() {
         width: 20,
         allowResize: false,
         allowMove: false,
-        allowSort: false,
       },
       {
         id: 'tags',

diff --git a/src/ui/translations/de/messages.po b/src/ui/translations/de/messages.po
@@ -2321,11 +2321,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr "Community gesperrt"
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr "Kommentar"
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"

diff --git a/src/ui/translations/en/messages.po b/src/ui/translations/en/messages.po
@@ -2316,11 +2316,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr "Community banned"
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr "Comment"
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"

diff --git a/src/ui/translations/es/messages.po b/src/ui/translations/es/messages.po
@@ -2321,11 +2321,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr ""
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr ""
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"

diff --git a/src/ui/translations/fr/messages.po b/src/ui/translations/fr/messages.po
@@ -2321,11 +2321,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr "Ban communautaire"
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr "Commentaire"
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"

diff --git a/src/ui/translations/pt-BR/messages.po b/src/ui/translations/pt-BR/messages.po
@@ -2321,11 +2321,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr "Banido na comunidade"
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr "Comentário"
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"

diff --git a/src/ui/translations/zh-CN/messages.po b/src/ui/translations/zh-CN/messages.po
@@ -2321,11 +2321,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr "社区封禁"
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr "评论"
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"

diff --git a/src/ui/translations/zh-TW/messages.po b/src/ui/translations/zh-TW/messages.po
@@ -2321,11 +2321,6 @@ msgctxt "Tooltip"
 msgid "Community banned"
 msgstr ""
 
-#: src/ui/components/table/cells/comment-cell.tsx
-msgctxt "Tooltip"
-msgid "Comment"
-msgstr ""
-
 #: src/ui/components/table/cells/kill-attributes-cell.tsx
 msgctxt "Tooltip kill"
 msgid "Headshot"