Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): error when demo path contains spaces #673

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

naextec
Copy link
Contributor

@naextec naextec commented Dec 6, 2023

Add escape characters for custom launch options in HLAE for paths with spaces.
Added quotes for FFMPEG arguments for paths with spaces.

@akiver
Copy link
Owner

akiver commented Dec 6, 2023

Thanks!
Could you change the commit message to something that follows this convention please? (example: fix(video): error when demo path contains spaces)
It helps generate the changelog.

@naextec naextec changed the title Fixes for issue #654 fix(video): error when demo path contains spaces Dec 6, 2023
@akiver akiver merged commit 0208ad2 into akiver:main Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants