Deprecate ClusterSingleton.Init() and add missing singleton feature to ClusterSingletonSettings
#7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arkatufus looks like API approvals are missing |
| /// <summary> | ||
| /// Returns default HOCON configuration for the cluster singleton. | ||
| /// </summary> | ||
| /// <returns>TBD</returns> |
Aaronontheweb
requested changes
Nov 14, 2024
| "Akka.Cluster.Tools.Singleton.reference.conf"); | ||
| } | ||
|
|
||
| // Cache for singleton proxies, remove in v1.6 | ||
| private readonly ConcurrentDictionary<string, IActorRef> _proxies = new(); |
There was a problem hiding this comment.
Yeah I agree we don't really need a cache for this - that's a little too clever for its own good.
| @@ -40,6 +54,10 @@ public ClusterSingleton(ExtendedActorSystem system) | |||
| /// <para>If there already is a proxy running for the given `singletonName` on this node, an <see cref="IActorRef"/> to that is returned.</para> | |||
| /// </summary> | |||
| /// <returns>A proxy actor that can be used to communicate with the singleton in the cluster</returns> | |||
| [Obsolete("This convenience method is deprecated and will be removed in v1.6, " + | |||
| "please use ClusterSingletonManager.Props and ClusterSingletonProxy.Props directly instead. " + | |||
| "See https://getakka.net/community/whats-new/akkadotnet-v1.5-upgrade-advisories.html#upgrading-to-akkanet-v1532. " + | |||
|
Updated the API Approval list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ClusterSingleton.Init()method and all of its supporting classesClusterSingletonSettings