feat: resource and concurrency settings #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
==========================================
- Coverage 50.09% 49.95% -0.14%
==========================================
Files 275 275
Lines 24427 24493 +66
==========================================
Hits 12236 12236
- Misses 11521 11587 +66
Partials 670 670 ☔ View full report in Codecov by Sentry. |
hiddeco
reviewed
Oct 29, 2024
hiddeco
reviewed
Oct 29, 2024
hiddeco
reviewed
Oct 29, 2024
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Kent Rancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bundle of resource utilization and concurrency improvements @hiddeco and I agreed on after extensively troubleshooting #2544 and #2836 with @wmiller112.
Sets GOMAXPROCS on all components to match (explicit or implicit) CPU limit on the container. i.e. GOMAXPROCS = cores available rounded up to the nearest integer. This prevents Go from backing goroutines with a number of OS threads exceeding the number of cores available, which is a condition that results in losing compute time to avoidable context switches. This value is logged at startup for all components to assist in troubleshooting efforts when necessary.
Sets GOMEMLIMIT (soft memory limit) on all components to match (explicit or implicit) memory limits on the container. This help Go to optimize GC. This value is logged at startup for all components to assist in troubleshooting efforts when necessary.
Allows
MaxConcurrentReconcilesto be set on a per-reconciler basis in both the controller(s) and management controller. There is a default of four for each. For Warehouses especially, the ability to tune this parameter may help decrease wait times for reconciliation of Warehouses overall when some Warehouses, due either to their configuration or to rate limits, take a long time to reconcile. The maximum number of concurrent reconciles for is logged at startup for all reconcilers to assist in troubleshooting efforts when necessary.