Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: random choose sample #42

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: random choose sample #42

wants to merge 3 commits into from

Conversation

Millione
Copy link
Contributor

#37

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.39 🎉

Comparison is base (d1fc4e8) 83.43% compared to head (c93fe98) 83.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   83.43%   83.83%   +0.39%     
==========================================
  Files          17       17              
  Lines        1920     1930      +10     
==========================================
+ Hits         1602     1618      +16     
+ Misses        318      312       -6     
Impacted Files Coverage Δ
src/policy.rs 94.47% <90.90%> (-0.27%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@al8n
Copy link
Owner

al8n commented Apr 18, 2023

Thanks! But let's wait for @alfa07 and @phantomhker's feedback about if the ringbuffer stuff solves the hit ratio problem mentioned in #37 because using rand will bring extra overhead for performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants