Skip to content

Commit

Permalink
fix(php8): update http_build_query() usage for PHP 8+ compatibility
Browse files Browse the repository at this point in the history
 - Changed second argument from  to an empty string  to ensure proper query string generation
 - This pr closes jumbojett#413
  • Loading branch information
alan199501 committed Sep 20, 2024
1 parent 97adbce commit b1f331c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.2] - 2024-09-20

### Fixed

- Fixed compatibility with PHP 8 and above by updating `http_build_query()` usage. The second argument was changed from `null` to an empty string `''` to ensure proper query string generation in PHP 8+ environments. #413

## [1.0.1] - 2024-09-13

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/OpenIDConnectClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ public function requestTokenExchange(string $subjectToken, string $subjectTokenT
}

// Convert token params to string format
$post_params = http_build_query($post_data, null, '&', $this->encType);
$post_params = http_build_query($post_data, '', '&', $this->encType);

return json_decode($this->fetchURL($token_endpoint, $post_params, $headers), false);
}
Expand Down

0 comments on commit b1f331c

Please sign in to comment.