Updating to 1.15.2 and build simplification #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulolc
changed the title
|
alecgorge
reviewed
May 3, 2020
Comment on lines
83
to
84
| //networkManagers = (List<Object>) FuzzyReflection.fromObject(serverConnection, true). | ||
| // invokeMethod(null, "getNetworkManagers", List.class, serverConnection); |
There was a problem hiding this comment.
why was this commented out?
my recollection was that this needs to be captured so that we don't interfere with the processing of packets for normal gameplay.
There was a problem hiding this comment.
Nice catch! I forgot that I had commented that out. I need to check it. Thanks!
It was raising a runtime exception due to not recognizing the getNetworkManagers method signature (maybe something to do with the 1.15.2 nms) and the method would not go until the end and jsonapi would break somewhere else. I commented it out just to see how far it went and it would run ok. Meanwhile I went full throttle on the build simplification and completely forgot about this. I'll have to recheck it.
Removed dead code Replaced debug preprocessing flag with configurable option Turned the forward ports checking verification on startup is now configurable (disabled by default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation now supports 1.15.2 (should resolve #517)
Build on top of @pawel8273 changes for 1.14.x.