Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional parameters of connect shim #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisguttandin
Copy link

Hi @alemangui,

I noticed a little bug which this pull request tries to fix. Since pizzicato patches the native AudioNode and doesn't pass on the optional parameters for the input and output channels it makes them inaccessible for any other code running on the same page.

Here is a little snippet which does currently not work when pizzicato is also loaded on the same page:

var splitter = ac.createChannelSplitter(2);
var merger = ac.createChannelMerger(2);

splitter.connect(merger, 1, 0);
splitter.connect(merger, 0, 1);

Please let me know if you want me to make changes to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant