Skip to content

Commit

Permalink
Update Prometheus exporter probes so they do not actually generate al…
Browse files Browse the repository at this point in the history
…l metrics (#3996)

* Update Prometheus exporter probes so they do not actually generate all metrics

Generating all metrics can take multiple seconds for large Aleph instances, which can make the liveness/readiness probe fail. The `name[]` query parameter can be used to select a subset of metrics the exporter should return (or no metrics as all in this case). That way, we can check that the exporter is up and running without actually generating any metrics.

* Slightly increase exporter default resources

This should be a little closer to real-world usage
  • Loading branch information
tillprochaska authored Nov 7, 2024
1 parent b91aa85 commit 7d4906a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
6 changes: 4 additions & 2 deletions helm/charts/aleph/templates/exporter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,14 @@ spec:
key: SENTRY_DSN
readinessProbe:
httpGet:
path: /metrics
# Unselect all metrics as generating them can take multiple seconds
path: /metrics?name[]=None
port: 9100
initialDelaySeconds: 5
livenessProbe:
httpGet:
path: /metrics
# Unselect all metrics as generating them can take multiple seconds
path: /metrics?name[]=None
port: 9100
initialDelaySeconds: 5
volumes:
Expand Down
6 changes: 3 additions & 3 deletions helm/charts/aleph/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ exporter:

containerResources:
requests:
memory: 250Mi
cpu: 10m
memory: 300Mi
cpu: 150m
limits:
memory: 500Mi
memory: 1Gi

0 comments on commit 7d4906a

Please sign in to comment.