Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #63

Merged
merged 7 commits into from
Aug 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,13 @@ You need to [create a personal access token](https://docs.github.com/en/authenti

### My code runs fine locally, but when I create a commit and submit it, it fails with `prettier code formatter workflow run failed for master branch`. How do I fix that?

We implemented support for [Prettier code formatting](https://prettier.io/) in [#2048](https://github.com/alshedivat/al-folio/pull/2048). It basically ensures that your code is well formatted. If you want to ensure your code is compliant with `Prettier` you can install it in your computer [integrated with an editor](https://prettier.io/docs/en/editors), [install it and run manually](https://prettier.io/docs/en/install), or you can disable it for your repo. For this, just delete the file [.github/workflows/prettier.yml](https://github.com/alshedivat/al-folio/blob/master/.github/workflows/prettier.yml).
We implemented support for [Prettier code formatting](https://prettier.io/) in [#2048](https://github.com/alshedivat/al-folio/pull/2048). It basically ensures that your code is [well formatted](https://prettier.io/docs/en/). If you want to ensure your code is compliant with `Prettier`, you have a few options:

- if you are running locally with `Docker` and using [development containers](https://github.com/alshedivat/al-folio/blob/master/INSTALL.md#local-setup-with-development-containers), `Prettier` is already included
- if you don't use `Docker`, it is simple to integrate it with your preferred IDE using an [extension](https://prettier.io/docs/en/editors)
- if you want to run it manually, you can follow the first 2 steps in [this tutorial](https://george-gca.github.io/blog/2023/slidev_for_non_web_devs/) (`Installing node version manager (nvm)` and `Installing Node (latest version)`), then, install it using `npm install prettier` inside the project directory, or install it globally on your computer using `npm install -g prettier`. To run `Prettier` on your current directory use `npx prettier . --write`.

You can also disable it for your repo. For this, just delete the file [.github/workflows/prettier.yml](https://github.com/alshedivat/al-folio/blob/master/.github/workflows/prettier.yml).

---

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ Feel free to add your own page(s) by sending a PR.
<a href="https://sraf.ir" target="_blank">★</a>
<a href="https://acad.garywei.dev/" target="_blank">★</a>
<a href="https://tonideleo.github.io/" target="_blank">★</a>
<a href="https://alonkellner.com/" target="_blank">★</a>
</td>
</tr>
<tr>
Expand Down
16 changes: 13 additions & 3 deletions _sass/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ table {
td,
th {
font-size: 1rem;
padding: 1px 1rem 1px 0;
}

th {
Expand Down Expand Up @@ -71,7 +72,10 @@ blockquote {
border-color: var(--global-tip-block);
background-color: var(--global-tip-block-bg);

p {
em,
li,
p,
strong {
color: var(--global-tip-block-text);
}

Expand All @@ -89,7 +93,10 @@ blockquote {
border-color: var(--global-warning-block);
background-color: var(--global-warning-block-bg);

p {
em,
li,
p,
strong {
color: var(--global-warning-block-text);
}

Expand All @@ -107,7 +114,10 @@ blockquote {
border-color: var(--global-danger-block);
background-color: var(--global-danger-block-bg);

p {
em,
li,
p,
strong {
color: var(--global-danger-block-text);
}

Expand Down
Loading