Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds --cert-only and --create-listener flags #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds --cert-only and --create-listener flags #17

wants to merge 1 commit into from

Conversation

klj613
Copy link

@klj613 klj613 commented Jan 25, 2016

The --cert-only flag will create the certificate and does not attempt to
add the certificate to the ELB. This would allow you to then create the
listener manually (or some other method) with the new certificate.

The --create-listener flag will create the listener for the certificate
if it doesn't exist.

@klj613
Copy link
Author

klj613 commented Jan 25, 2016

Tested as much as I can. I've reached letsencrypt's rate limit currently.

@klj613
Adds --cert-only and --create-listener flags
fd4bdbd 
The --cert-only flag will create the certificate and does not attempt to
add the certificate to the ELB. This would allow you to then create the
listener manually (or some other method) with the new certificate.

The --create-listener flag will create the listener for the certificate
if it doesn't exist.
@mattyway
Copy link

This patch worked well for me 👍

kageurufu added a commit to kageurufu/letsencrypt-aws that referenced this pull request May 11, 2016
@kageurufu
Add Cloudfront and ElasticBeanstalk support
cdaf9f3 
Refactor Certificates into AWSCertificate sub-classes,
 allowing for the easy adding of new listener providers
 in the future. CloudFront and ElasticBeanstalk are both
 implemented this way. Fix alex#41

Also, add the --cert-only flag, fix alex#13

This PR supersedes alex#44 and partially alex#17
@kageurufu kageurufu mentioned this pull request May 11, 2016
Closed
@tj
Copy link

tj commented May 11, 2016

I get:

TypeError: request_domain_challenges() got an unexpected keyword argument 'new_authz_uri'

@rucksacklabs
Copy link

@tj @klj613 there is a typo in line 175, new_authz_uri is supposed to be new_authzr_uri.
Change that and it will work fine.

    authz = acme_client.request_domain_challenges(
        host, new_authzr_uri=acme_client.directory.new_authz
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klj613 @mattyway @tj @rucksacklabs