fix checkstyle errors

alexciornei22 · Nov 24, 2022 · 848bdff · 848bdff
1 parent 4732c4a
commit 848bdff
Show file tree

Hide file tree

Showing 43 changed files with 510 additions and 740 deletions.
diff --git a/checkstyle.txt b/checkstyle.txt
diff --git a/src/main/Deck.java b/src/main/Deck.java
@@ -1,7 +1,6 @@
 package main;
 
 import fileio.CardInput;
-import fileio.DecksInput;
 import main.card.Card;
 import main.card.EnvironmentCard;
 import main.card.MinionCard;
@@ -11,22 +10,23 @@
 
 import java.util.ArrayList;
 
-public class Deck {
-    ArrayList<Card> cards = new ArrayList<>();
+public final class Deck {
+    private final ArrayList<Card> cards = new ArrayList<>();
 
-    public Deck(ArrayList<CardInput> deckInput) {
+    public Deck(final ArrayList<CardInput> deckInput) {
         deckInput.forEach(cardInput -> {
             if (Game.ENVIRONMENT_CARDS.contains(cardInput.getName())) {
                 switch (cardInput.getName()) {
-                    case "Firestorm":
-                        cards.add(new EnvironmentCard(cardInput, new Firestorm()));
-                        break;
-                    case "Winterfell":
-                        cards.add(new EnvironmentCard(cardInput, new Winterfell()));
-                        break;
-                    case "Heart Hound":
-                        cards.add(new EnvironmentCard(cardInput, new HeartHound()));
-                        break;
+                    case "Firestorm" -> cards.add(
+                            new EnvironmentCard(cardInput, new Firestorm())
+                    );
+                    case "Winterfell" -> cards.add(
+                            new EnvironmentCard(cardInput, new Winterfell())
+                    );
+                    case "Heart Hound" -> cards.add(
+                            new EnvironmentCard(cardInput, new HeartHound())
+                    );
+                    default -> { }
                 }
             } else {
                 cards.add(new MinionCard(cardInput));
@@ -37,8 +37,4 @@ public Deck(ArrayList<CardInput> deckInput) {
     public ArrayList<Card> getCards() {
         return cards;
     }
-
-    public void setCards(ArrayList<Card> cards) {
-        this.cards = cards;
-    }
 }