-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor brushless support #86
Conversation
This makes saxi buildable on a raspberry pi zero (webpack OOMs even with 1.5Gb of memory). This also enables live-reload during development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will continue giving file-by-file context soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change is making the type of --hardware
an enum. Everything else is just style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making --hardware
an enum
@alexrudd2 mind rebasing your brushless branch on top of your main to include the esbuild stuff? |
f061831
to
a2ee760
Compare
Ok, done. Not tested, though :) |
I'm OK with all your changes generally, but this branch has gotten really unwieldy. Please check out #87, which clears up some of the merge conflicts. Also, it would be easier to land a lot of the stuff (like the formatting, or splitting the ts-config) separately. |
Apologies for all the extra work I made, I am going to close this PR and work off the other one. |
This is based off the esbuild branch, and contains a mix of things.
Apologies for mixing a few different things, hopefully its a legible PR otherwise.
Changes
minPenPosition
to Plan, which I think is different for each kind of hardwarePlanning.plan
com
path used in the server to all websockets (was hardcoded to/dev/XXX
before)Refactoring
--hardware
cli option to be global, so it can be used insaxi plot
.brushless
from a boolean tohardware
enumhardware
to PlanOptions, so thatPlanning.plan
workshardware
in the future with further refactoring