Start using CSS variables in place of Sass #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Sass is a bit of a mess: I support custom colours per page, plus dark mode, plus a bunch of complexity I've built around the Sass preprocessor. The result is that it's hard to find where CSS stuff is defined and it's often split across multiple files. Yuck!
It's 2024. CSS variables are in 97.47% of browsers. They make a lot of this stuff much easier, so I should use them. (And if you're running a super old browser, you'll get the default colours and/or sans-CSS styling, which should still be fine, given I'm using a lot of semantic HTML.)
This patch takes the first step in that direction:
componentsnamespace for SCSS files, to make stuff easier to find_settings.scss/variables.scss, which is a remnant of a long-ago refactorFor #741