MAGE-1004 Babel transpiler fix #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
previously approved these changes
Jan 21, 2025
There was a problem hiding this comment.
So if I understood correctly, the only difference with #1678 is the last commit about the Babel compatibility. Now that the 3.15.0-dev branch has been updated by the other PR, is it okay to merge this one which also contains all the previous commits ? Or maybe we should create a new PR with only the last commit ?
In any case, I tested the bundling and it seems to work as expected :)
|
Thank you @damcou - yup it's just one simple commit to address a transpiling issue. I thought Github would rebase post merge on the previous PR but it didn't. However, I was able to "trick" Github into rebasing by temporarily retargeting the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small but necessary change from #1678 and is to be used in tandem with the Babel compilation steps from the companion PR outlined in Jira.