feat: adds null search service for testing #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chloelbn
force-pushed
the
feat/nullsearchservice
branch
from
801da27 to
cfd9de8
Compare
chloelbn
force-pushed
the
feat/nullsearchservice
branch
from
cfd9de8 to
0149a06
Compare
aseure
approved these changes
Nov 7, 2019
|
@aseure I had the same tought! My guess was that it was removed for arguments that are typed because the tools can already infer whatever is interesting. |
julienbourdeau
approved these changes
Nov 7, 2019
|
@aseure @julienbourdeau indeed now php-cs-fixer raises errors when you both type-hint parameters and add doc blocks |
Ant-hem
approved these changes
Nov 7, 2019
nunomaduro
suggested changes
Nov 7, 2019
nunomaduro
changed the title
chloelbn
force-pushed
the
feat/nullsearchservice
branch
from
998fbad to
6faf0be
Compare
chloelbn
force-pushed
the
feat/nullsearchservice
branch
from
6faf0be to
72a71ca
Compare
nunomaduro
suggested changes
Nov 14, 2019
nunomaduro
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
We deleted
NullEnginewithout providing an alternate example class to mock your searchService. This fixes it.