Skip to content

Commit

Permalink
CI: update reviewdog config for deprecated fail_on_error (#6196)
Browse files Browse the repository at this point in the history
  • Loading branch information
cce authored Dec 19, 2024
1 parent 548e3f6 commit a625d03
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:
- name: Make libsodium.a
run: sudo mv /usr/bin/go /usr/bin/go.bak && make crypto/libs/linux/amd64/lib/libsodium.a && sudo mv /usr/bin/go.bak /usr/bin/go
- name: reviewdog-golangci-lint
uses: reviewdog/action-golangci-lint@v2.6.2
uses: reviewdog/action-golangci-lint@v2.7.0
with:
go_version_file: go.mod
golangci_lint_version: ${{ env.GOLANGCI_LINT_VERSION }}
golangci_lint_flags: "-c .golangci.yml --allow-parallel-runners"
reporter: "github-pr-check"
tool_name: "Lint Errors"
level: "error"
fail_on_error: true
fail_level: any
filter_mode: "nofilter"
# Non-Blocking Warnings Section
reviewdog-warnings:
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
cd ../../
- name: Install reviewdog
run: |
curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/v0.20.2/install.sh | sh -s -- v0.20.2
curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/v0.20.3/install.sh | sh -s -- v0.20.3
reviewdog --version
- name: Build custom linters
run: |
Expand All @@ -96,7 +96,7 @@ jobs:
-name="Lint Warnings" \
-reporter=github-pr-check \
-filter-mode=added \
-fail-on-error=true \
-fail-level=any \
-level=warning
- name: Slack Notification
env:
Expand All @@ -109,11 +109,11 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: shellcheck
uses: reviewdog/action-shellcheck@v1
uses: reviewdog/action-shellcheck@v1.28.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: "github-pr-check"
shellcheck_flags: "-e SC2034,SC2046,SC2053,SC2207,SC2145 -S warning"
fail_on_error: true
fail_level: any
path: |
test/scripts/e2e_subs

0 comments on commit a625d03

Please sign in to comment.