Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-algorand 4.0.2-beta Release PR #6252

Merged
merged 28 commits into from
Feb 12, 2025

Conversation

Algo-devops-service
Copy link
Contributor

@Algo-devops-service Algo-devops-service commented Feb 12, 2025

GitHub Logo

Overview

This release fixes an occasional issue with catchpoint file consistency. Additionally, a change to requesting block headers from the API was included, to fix issues generating downstream SDKs.

What's New

  • Update to catchpoint generation
  • Move block header requests to block endpoint and make cert and paysets optional
  • Devmode: zero out ProposerPayout when Proposer not set

Changelog

Enhancements

  • Build: upgrade minimum MacOS version to 13 (#6223)
  • Catchpoints: log ledger download failures (#6227)
  • Comments: Correct deadline comment issue#6201 (#6241)
  • Db: Remove AtomicContextWithRetryClearFn, rename to AtomicContext (#6231)
  • P2p: exclude self from GetPeers results (#6132)
  • Refactor: using slices.Contains to simplify the code (#6234)
  • Tests: add catchpoint downloading/parsing to e2e catchup tests (#6224)

Bugfixes

  • API: Block Header API Revamp (#6248)
  • API: Explicitly set the x-algorand-format for BlockHeaderResponse to 'Bloc… (#6247)
  • Catchpoints: add accountsRound check against R-320 horizon values to catchpointFileWriter (#6240)
  • Devmode: Zero out ProposerPayout when Proposer is not set (which i… (#6239)
  • Tests: Don't fail for heartbeat in same block as proposal (#6229)
  • Tests: Moar unflaky (#6228)

Protocol Upgrade

This release does not contain a protocol upgrade.

Additional Resources

cce and others added 28 commits January 9, 2025 09:30
…rand#6219)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove unused EnableOnlineAccountCatchpoints
* rename EnableAccountDataResourceSeparation
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 17.46725% with 189 lines in your changes missing coverage. Please review.

Project coverage is 51.79%. Comparing base (a92bb19) to head (33cdcd7).
Report is 29 commits behind head on rel/beta.

Files with missing lines Patch % Lines
cmd/catchpointdump/info.go 0.00% 131 Missing ⚠️
daemon/algod/api/server/v2/handlers.go 0.00% 19 Missing ⚠️
...edger/store/trackerdb/sqlitedriver/sqlitedriver.go 0.00% 7 Missing ⚠️
cmd/catchpointdump/net.go 0.00% 6 Missing ⚠️
...ver/v2/generated/nonparticipating/public/routes.go 0.00% 5 Missing ⚠️
catchup/catchpointService.go 0.00% 3 Missing ⚠️
ledger/catchpointfilewriter.go 90.00% 1 Missing and 1 partial ⚠️
ledger/catchupaccessor.go 33.33% 2 Missing ⚠️
network/p2pNetwork.go 60.00% 1 Missing and 1 partial ⚠️
node/node.go 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##           rel/beta    #6252      +/-   ##
============================================
- Coverage     52.04%   51.79%   -0.25%     
============================================
  Files           649      644       -5     
  Lines         86459    86494      +35     
============================================
- Hits          44995    44800     -195     
- Misses        38615    38828     +213     
- Partials       2849     2866      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits list LGTM

@onetechnical onetechnical self-assigned this Feb 12, 2025
@algojohnlee algojohnlee merged commit 04909c4 into algorand:rel/beta Feb 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants