-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewind: Re-enable Rewinding #1645
Conversation
…ps and searches. (algorand#1630)" This reverts commit 249016c. The synthetic transaction implementation of payouts in the indexer should allow balances retrieved via rewind to calculate as before.
Should we add a test to show it works with incentive payouts? I don't know enough about how indexer is tested to know if that's a big ask. |
I wasn't planning to; the payout is itself a pay transaction and has tests ensuring indexer handles it. The existing rewind tests are light for sure, IOW I personally wouldn't hold this PR up for it. |
Does this mean the rewind works and the conditions existed that necessitated the removal is no longer there? |
Rewind works again, but only as well as it has in the past. App and keyreg transactions still cannot be rewound. |
Summary
Revert "Disable rewinding and reject the query param on account lookups and searches. (#1630)"
This reverts commit 249016c. The synthetic transaction implementation of payouts in the indexer should allow balances retrieved via rewind to calculate as before.
Test Plan
Pre-existing tests were added back.