Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewind: Re-enable Rewinding #1645

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Rewind: Re-enable Rewinding #1645

merged 3 commits into from
Jan 13, 2025

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Jan 13, 2025

Summary

Revert "Disable rewinding and reject the query param on account lookups and searches. (#1630)"

This reverts commit 249016c. The synthetic transaction implementation of payouts in the indexer should allow balances retrieved via rewind to calculate as before.

Test Plan

Pre-existing tests were added back.

…ps and searches. (algorand#1630)"

This reverts commit 249016c. The synthetic transaction implementation of payouts in the indexer should allow balances retrieved via rewind to calculate as before.
@gmalouf gmalouf added the Enhancement New feature or request label Jan 13, 2025
@gmalouf gmalouf self-assigned this Jan 13, 2025
@jannotti
Copy link
Contributor

Should we add a test to show it works with incentive payouts? I don't know enough about how indexer is tested to know if that's a big ask.

@gmalouf gmalouf marked this pull request as ready for review January 13, 2025 18:44
@gmalouf
Copy link
Contributor Author

gmalouf commented Jan 13, 2025

Should we add a test to show it works with incentive payouts? I don't know enough about how indexer is tested to know if that's a big ask.

I wasn't planning to; the payout is itself a pay transaction and has tests ensuring indexer handles it. The existing rewind tests are light for sure, IOW I personally wouldn't hold this PR up for it.

@gmalouf gmalouf requested a review from jannotti January 13, 2025 19:34
@gmalouf gmalouf merged commit 0845773 into algorand:main Jan 13, 2025
5 checks passed
@gmalouf gmalouf deleted the re-enable-rewind branch January 13, 2025 21:04
@cshintov
Copy link
Contributor

Does this mean the rewind works and the conditions existed that necessitated the removal is no longer there?

@jannotti
Copy link
Contributor

Does this mean the rewind works and the conditions existed that necessitated the removal is no longer there?

Rewind works again, but only as well as it has in the past. App and keyreg transactions still cannot be rewound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants