Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Address as an ABIValue and handle encoding an Address #911

Merged
merged 2 commits into from
Feb 5, 2025
Merged

feat: add Address as an ABIValue and handle encoding an Address #911

merged 2 commits into from
Feb 5, 2025

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Dec 13, 2024

Allows Address to be an acceptable ABIValue and properly handles Address in ABIAddressType.encode

@gmalouf
Copy link
Contributor

gmalouf commented Feb 4, 2025

@joe-p can you add test coverage for this?

@joe-p joe-p force-pushed the feat/address_abi_value branch from 4137ff3 to f9dceaf Compare February 4, 2025 22:45
@joe-p
Copy link
Contributor Author

joe-p commented Feb 4, 2025

Added test case in f9dceaf. See header comment for implementation rationale.

Also rebased against develop

@gmalouf gmalouf merged commit bce7735 into algorand:develop Feb 5, 2025
3 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalouf gmalouf gmalouf approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-p @gmalouf