fix: avoid infinite setOutlets loop when config keepAlivePaths (#6995)

alibaba · Oct 8, 2024 · 3170603 · 3170603
1 parent f50fe55
commit 3170603
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/happy-cars-punch.md b/.changeset/happy-cars-punch.md
@@ -0,0 +1,5 @@
+---
+'@ice/runtime': patch
+---
+
+fix: avoid infinite setOutlets loop when config keepAlivePaths
diff --git a/packages/runtime/src/KeepAliveOutlet.tsx b/packages/runtime/src/KeepAliveOutlet.tsx
@@ -41,10 +41,11 @@ export default function KeepAliveOutlet(props: OutletProps) {
     if (outlets.length !== 0 ||
       outletRef.current?.pathname !== location.pathname) {
       let currentOutlets = outletRef.current ? [outletRef.current] : outlets;
+      // Check current path if exsist before filter, to avoid infinite setOutlets loop.
+      const result = currentOutlets.some(o => o.pathname === location.pathname);
       if (keepAlivePaths && keepAlivePaths.length > 0) {
         currentOutlets = currentOutlets.filter(o => keepAlivePaths.includes(o.pathname));
       }
-      const result = currentOutlets.some(o => o.pathname === location.pathname);
       if (!result) {
         setOutlets([
           ...currentOutlets,