Intrinsics update after auto reorientation #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otation due to auto orientation instead of modifying the existing one. Hence we avoid undefined behavior when the images to process are not all oriented in the same way.
CedricThebault
approved these changes
Nov 16, 2023
cbentejac
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the intrinsic parameters when an automatic reorientation applied on an image lead to an image rotation. In that case, a new set of intrinsic parameters is derived from the original one and associated to the image view.
In addition, this PR fixes a bug that occurs when the original image does not contain any metadata named "Orientation".
Features list
Implementation remarks