-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add camera color spaces #1597
Merged
Merged
Add camera color spaces #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
force-pushed
the
dev/addCameraColorSpaces
branch
from
December 21, 2023 13:51
984fabe
to
6fd2790
Compare
cbentejac
force-pushed
the
dev/addCameraColorSpaces
branch
2 times, most recently
from
January 30, 2024 10:21
e8b0e1c
to
e8eb0eb
Compare
cbentejac
force-pushed
the
dev/addCameraColorSpaces
branch
2 times, most recently
from
January 31, 2024 14:44
a7d6bc4
to
d84f565
Compare
fabiencastan
approved these changes
Jan 31, 2024
… Sony, Panasonic and BlackMagic cameras.
…parameters values which are not of type string (enum for instance) but that contain at least one white space character. Such a configuration is not supported by Boost::program_options.
S-Log3 Venice S-Gamut3.Cine was present in all the enum to string and string to enum conversions except for the enum to OIIO string.
The `>>` operator needed to parse all the provided input string instead of stopping at the first encountered space.
fcastan
force-pushed
the
dev/addCameraColorSpaces
branch
from
January 31, 2024 20:57
d84f565
to
a2b490d
Compare
fabiencastan
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds native support of the following camera color spaces through an updated "ocio.config" file:
ARRI:
Linear ARRI Wide Gamut_3
ARRI LogC3 (EI800)
Linear ARRI Wide Gamut_4
ARRI LogC4
Black Magic:
Linear BMD Wide Gamut Gen5
BMD Film Wide Gamut Gen5
Canon:
CanonLog2 Cinema Gamut D55
CanonLog3 Cinema Gamut D55
Linear Cinema Gamut D55
Panasonic:
Linear V Gamut
V Log V Gamut
RED:
Linear RED Wide Gamut RGB
Log3G10 RED Wide Gamut RGB
Sony:
Linear Venice S Gamut3 Cine
S Log3 Venice S Gamut3 Cine
linked to Meshroom PR: alicevision/Meshroom#2251
Features list
Implementation remarks