Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera color spaces #1597

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Add camera color spaces #1597

merged 9 commits into from
Feb 2, 2024

Conversation

demoulinv
Copy link
Contributor

Description

This PR adds native support of the following camera color spaces through an updated "ocio.config" file:

ARRI:
Linear ARRI Wide Gamut_3
ARRI LogC3 (EI800)
Linear ARRI Wide Gamut_4
ARRI LogC4

Black Magic:
Linear BMD Wide Gamut Gen5
BMD Film Wide Gamut Gen5

Canon:
CanonLog2 Cinema Gamut D55
CanonLog3 Cinema Gamut D55
Linear Cinema Gamut D55

Panasonic:
Linear V Gamut
V Log V Gamut

RED:
Linear RED Wide Gamut RGB
Log3G10 RED Wide Gamut RGB

Sony:
Linear Venice S Gamut3 Cine
S Log3 Venice S Gamut3 Cine

linked to Meshroom PR: alicevision/Meshroom#2251

Features list

Implementation remarks

@demoulinv demoulinv force-pushed the dev/addCameraColorSpaces branch from 984fabe to 6fd2790 Compare December 21, 2023 13:51
@fabiencastan fabiencastan marked this pull request as ready for review January 11, 2024 16:20
@fabiencastan fabiencastan added this to the 3.3.0 milestone Jan 11, 2024
@cbentejac cbentejac force-pushed the dev/addCameraColorSpaces branch 2 times, most recently from e8b0e1c to e8eb0eb Compare January 30, 2024 10:21
@cbentejac cbentejac force-pushed the dev/addCameraColorSpaces branch 2 times, most recently from a7d6bc4 to d84f565 Compare January 31, 2024 14:44
demoulinv and others added 9 commits January 31, 2024 18:16
…parameters values which are not of type string (enum for instance) but that contain at least one white space character. Such a configuration is not supported by Boost::program_options.
S-Log3 Venice S-Gamut3.Cine was present in all the enum to string and
string to enum conversions except for the enum to OIIO string.
The `>>` operator needed to parse all the provided input string instead
of stopping at the first encountered space.
@fcastan fcastan force-pushed the dev/addCameraColorSpaces branch from d84f565 to a2b490d Compare January 31, 2024 20:57
@fabiencastan fabiencastan merged commit 3612d53 into develop Feb 2, 2024
4 checks passed
@fabiencastan fabiencastan deleted the dev/addCameraColorSpaces branch February 2, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants