Image segmentation cpu bugfix and onnx output update #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
requested review from
fabiencastan,
cbentejac and
servantftechnicolor
cbentejac
force-pushed
the
bugfix/imageSegmentationOnnxOutput
branch
from
c3e9a47 to
596e032
Compare
cbentejac
force-pushed
the
bugfix/imageSegmentationOnnxOutput
branch
from
596e032 to
0fc2633
Compare
cbentejac
force-pushed
the
bugfix/imageSegmentationOnnxOutput
branch
from
0fc2633 to
77a5760
Compare
jgoueslard
suggested changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the access to the output of the onnx model using the dedicated 'At' accessor in image segmentation. This is a safer method than accessing with a pointer because onnx does not guarantee that the allocated memory is contiguous.
It also fixes a bug when using the cpu mode by avoiding freeing cuda memory in this case.
Features list
Implementation remarks