David/noasync arbitrary objectref #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindkhare
reviewed
Apr 2, 2021
| def set_traffic(self, service, traffic_dict): | ||
| #logger.debug("Setting traffic for service %s to %s", service, traffic_dict) | ||
| self.traffic[service] = traffic_dict | ||
| self.flush() |
There was a problem hiding this comment.
This flush should happen asynchronously. Which means you need to do something like self._router_actor_handle.flush.remote()
There was a problem hiding this comment.
You can register's actor's handle inside it's own actor.
alindkhare
reviewed
Apr 2, 2021
| self_handle = None | ||
|
|
||
| def register_self_handle(self, handle_to_this_actor): | ||
| self.self_handle = handle_to_this_actor |
There was a problem hiding this comment.
this is what I am talking about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.