[Core] Adding option to avoid Plasma Fetch and Deserialisation + e2e benchmarks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GPU num_gpus=1 for replicas Intermediate tensor is torch tensor Only 1 iteration is enough for calculating throughput and closed loop latency Image as raw bytes Removed the need to pass args as list for enqueue remote Added server code Error Fix Added server code Fix bug for subprocess submission Few more print fixes Fire more queries to see
Final config Final Config
alindkhare
commented
Feb 17, 2021
src/ray/core_worker/core_worker.cc
Outdated
Comment on lines
2499
to
2507
| memory_store_->GetAsync( | ||
| object_id, [python_future, success_callback, fallback_callback, object_id, | ||
| fetch_plasma_data](std::shared_ptr<RayObject> ray_object) { | ||
| if (ray_object->IsInPlasmaError() && fetch_plasma_data) { | ||
| fallback_callback(ray_object, object_id, python_future, fetch_plasma_data); | ||
| } else { | ||
| success_callback(ray_object, object_id, python_future); | ||
| } | ||
| }); |
There was a problem hiding this comment.
@atumanov This is the main change that I made
Performance Benchmark Results
Latency Table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.