New README #17
Merged
New README #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alissonperez
force-pushed
the
new-docs
branch
2 times, most recently
from
6e53f62 to
07098e4
Compare
alissonperez
force-pushed
the
new-docs
branch
7 times, most recently
from
ce24b9f to
c5d4c1c
Compare
|
@guicheffer Please, give me a review for what I had written until now! ❤️ |
alissonperez
force-pushed
the
new-docs
branch
3 times, most recently
from
0eafcb6 to
d4519e5
Compare
guicheffer
reviewed
Jul 17, 2018
| otherInt: 10 | ||
| } | ||
| } | ||
| title: 'Star Wars: Episode V - The Empire Strikes Back', |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
README.md
Outdated
| } | ||
|
|
||
| // Pay attention here, picker instance is with 'nextMovie' context, | ||
| // so, when we call "pick" method it knows exactally what needs to cut |
There was a problem hiding this comment.
sounds better whether needs to be cut out or not
|
|
||
| Ok, what happend?! | ||
|
|
||
| First of all, we didn't ask for "previousMovie", so deepicker don't evaluate this function. In this example this don't affect performance, but thinking about an operation like access to a database to get something or call some API this can increase performance significantly. The main gain here is **we process only what client asks for**. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
README.md
Outdated
| description: 'The galaxy is in the midst of a civil war. Spies for the Rebel Alliance have stolen plans...', | ||
| releaseYear: 1977, | ||
|
|
||
| // Using a function to computate otherInfo about Episode IV |
| Here we'll resolve a function in our object and items of an array. | ||
| #### Using nested functions | ||
|
|
||
| But we know, unfortunatelly, real life "usually" is not so simple. Thinking about it, Deepicker is able to handle a lot of data types inside our objects, like arrays, promises, functions... etc. And with this last data type is where Deepicker really shines and show its power! =) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| { name: 'Luke Skywalker', actor: 'Mark Hamill' }, | ||
| { name: 'Han Solo', actor: 'Harrison Ford' }, | ||
| { name: 'Princess Leia Organa', actor: 'Carrie Fischer' }, | ||
| { name: 'Darth Vader', actor: 'James Earl Jones' }, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
README.md
Outdated
| - Simple implementation. | ||
| - Increases performance processing only what client asks for. | ||
| - Non-blocking processing, it handles promisses in parallel very well. | ||
| - Simple usage by clients. Just receive an `include` and `exclude` querystring and send then to Deepicker. |
| or, if you prefer `yarn`: | ||
|
|
||
| ```bash | ||
| $ yarn add deepicker |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
so far too great @alissonperez Please let me know (even am watchin to this) whether you have things to be reviewed 😍 |
|
@guicheffer Thank you very much!! Awesome!! I'll fix your points ASAP! |
|
@guicheffer Done, thanks! I'll work more on this today later! |
|
|
alissonperez
force-pushed
the
new-docs
branch
2 times, most recently
from
9c7b95e to
bc77618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #13
Description
New README with a decent documentation.
Motivation, Consideration and Context
It is now a piece of junk!
Checklist:
Additional: