fix(taskgroup): failed group tasks not counted #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
group.go
file to improve task submission handling and adds new test cases to ensure the functionality of task group metrics and handling of cancelled contexts.Improvements to task submission:
submit
function to useg.pool.dispatcher.Write
for task execution, which returns an error if the context is cancelled or an error occurs during task invocation. (group.go
, group.goL107-R115)group.go
, group.goR125-R126)New test cases:
TestTaskGroupMetrics
to verify the correct reporting of submitted, successful, and failed tasks. (group_test.go
, group_test.goR326-R371)TestTaskGroupMetricsWithCancelledContext
to test the behavior of task groups when the context is cancelled, ensuring accurate metrics for successful and failed tasks. (group_test.go
, group_test.goR326-R371)