Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Fix builds on Python < 3.12 #583

Merged
merged 9 commits into from
Nov 7, 2024
Merged

[MRG] Fix builds on Python < 3.12 #583

merged 9 commits into from
Nov 7, 2024

Conversation

aaronreidsmith
Copy link
Member

@aaronreidsmith aaronreidsmith commented Sep 24, 2024 •
edited
Loading

Description

Sets SETUPTOOLS_USE_DISTUTILS=stdlib where necessary to get builds working again

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Builds working again

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith changed the title [WIP] Build on setuptools 72 [WIP] Fix builds Sep 25, 2024
@aaronreidsmith aaronreidsmith changed the title [WIP] Fix builds [WIP] Fix builds on Python < 3.12 Sep 25, 2024
@aaronreidsmith aaronreidsmith changed the title [WIP] Fix builds on Python < 3.12 [MRG] Fix builds on Python < 3.12 Sep 25, 2024
@tgsmith61591 tgsmith61591 merged commit 22cb5ce into master Nov 7, 2024
29 checks passed
@tgsmith61591 tgsmith61591 deleted the fix-build branch November 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgsmith61591 tgsmith61591 tgsmith61591 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronreidsmith @tgsmith61591