fix: fix support for usernames with multiple dashes

all-contributors · May 9, 2023 · 8a84507 · 8a84507
1 parent 205ccee
commit 8a84507
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/parse-comment.js b/lib/parse-comment.js
@@ -133,7 +133,7 @@ nlp.plugin(plugin);
 
 function findWho(message, action) {
   function findWhoSafe(match) {
-    message = message.replace("-", "#/#"); // workaround (https://github.com/spencermountain/compromise/issues/726)
+    message = message.replace(/\-/g, "#/#"); // workaround (https://github.com/spencermountain/compromise/issues/726)
     const whoNormalizeSettings = {
       whitespace: true, // remove hyphens, newlines, and force one space between words
       case: false, // keep only first-word, and 'entity' titlecasing
@@ -155,7 +155,7 @@ function findWho(message, action) {
 
     if (matchedSet.length > 0) {
       matchedText = matchedSet[0].text;
-      matchedText = matchedText.replace("#/#", "-");
+      matchedText = matchedText.replace(/#\/#/g, "-");
 
       return matchedText;
     }

diff --git a/test/unit/parse-comment.test.js b/test/unit/parse-comment.test.js
@@ -62,6 +62,17 @@ describe('parseComment', () => {
       })
   })
 
+  test('Basic intent to add - username with multiple dashes', () => {
+    expect(
+        parseComment(`@${testBotName} please add rishi-raj-jain for doc`),
+    ).toEqual({
+        action: 'add',
+        contributors: {
+            "rishi-raj-jain": ['doc'],
+        },
+    })
+})  
+
   test('Basic intent to add - with plurals', () => {
       expect(
           parseComment(`@${testBotName} please add dat2 for docs`),