Release attrs upper bound #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhenning
reviewed
Nov 8, 2022
| @@ -1,4 +1,4 @@ | |||
| attrs>=18.0,<20.4.0 | |||
| attrs>=18.0 | |||
There was a problem hiding this comment.
Since we need to safeguard against potential backward compatibility issues (or problematic versions), we'd rather limit the version here - we can limit to ,<22.1.0 which is the latest version at the moment and seems to be stable
|
Hi @Honzys, Sorry for the delay - I've added a small comment 🙂 |
jkhenning
reviewed
Nov 8, 2022
| @@ -1 +1 @@ | |||
| __version__ = '1.4.1' | |||
| __version__ = '1.4.2' | |||
There was a problem hiding this comment.
Please remove this change as this is already set to 1.5.0rc0
|
@Honzys , can you commit the above fixes so we can merge the PR? 😄 |
|
@Honzys is this PR still relevant? |
|
@Honzys can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102