Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If enabling compilation for x64, MSVC will complain a lot about this line
*(reinterpret_cast<void**>(&mfp) + 1) = 0;
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4789
So let's hide to msvc by adding an extra variable that this is a member function pointer, so it stops screaming about it.
Edit: Just in case there's confusion why msvc isn't ignoring this part of the code despite the static if statement right above
if (sizeof(mfp) == 2*sizeof(void*))
the answer is I've no idea. I did a static assert though, in the event that it evaluated to true. But no it doesn't. Msvc just decides to care about this unreachable part of the code, just because.... And I opt'd for this solution, instead of adding even more macros and ifdef.