Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut msvc #161

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Shut msvc #161

merged 1 commit into from
Feb 8, 2024

Conversation

Kenzzer
Copy link
Member

@Kenzzer Kenzzer commented Feb 4, 2024

If enabling compilation for x64, MSVC will complain a lot about this line
*(reinterpret_cast<void**>(&mfp) + 1) = 0;
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4789

So let's hide to msvc by adding an extra variable that this is a member function pointer, so it stops screaming about it.

Edit: Just in case there's confusion why msvc isn't ignoring this part of the code despite the static if statement right above
if (sizeof(mfp) == 2*sizeof(void*)) the answer is I've no idea. I did a static assert though, in the event that it evaluated to true. But no it doesn't. Msvc just decides to care about this unreachable part of the code, just because.... And I opt'd for this solution, instead of adding even more macros and ifdef.

@psychonic psychonic merged commit 3740821 into alliedmodders:master Feb 8, 2024
4 checks passed
zer0k-z pushed a commit to zer0k-z/metamod-source that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants