Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused features #142

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Deprecate unused features #142

merged 14 commits into from
Oct 9, 2024

Conversation

alloncm
Copy link
Owner

@alloncm alloncm commented Sep 20, 2024 •
edited
Loading

Delete the following unused features:

  • u16pixels - made this the default, no reason to use bigger pixel size
  • sdl-resample - the current implementation was more robust (works with larger range of frequencies) and faster
  • push-audio - the usage of push methodology is wrong for a constant stream if content that need to stay synced (with the video) so the pull methodology even though is more unsafe, complex and contains more code is faster and results in better experience

Also refactor some issues, improved the pull audio implementation and update dependencies.

Fixes #132
Fixes #128
Fixes #141

@alloncm
Deprecate the u16pixel feature
a3b8b5a 
make it the default, since the gameboy color can only output u16 pixels we dont have reason to use u32 anyway
@alloncm
Delete scale.c
b2c2230 
it was in use only for benchmark
@alloncm
Remove usage of image crate from the integration tests
0061fcf
@alloncm
Deprecate sdl-reasmple and push-audio features from the sdl frontend
85ca142 
They were not used and its code started to rot
@alloncm
Improve sdl audio implementation
1332fb5 
Also renamed and moved code from utils
@alloncm
Fix tests not working on windows 10 with rust 1.79
d21972b
@alloncm
Fix bugs in the rgb888 -> rgb555 conversion
43008ac 
The From<Color> for Pixel impl flipped the endianess of the rgb fields

The sdl pixel format was flipped

Sine both of those bugs happened the canceled each other and I found it only when trying to fix the integration tests

Still need to verify this (and probably fix) in the ili9341 driver
@alloncm
Fixed most of the tests and update deps
30cc2bb 
Update openssl to fix security issue and update reqwest on the way

Still need to fix cpu_instrs test as the calc hash would stop before the rom finishes execution (found thank to the bmp output
@alloncm
Limit image to include only bmp
48ff126 
this reduces the amount the dpes by alot
@alloncm
Fix dbg feature support (does not compile)
0c1196d 
Also trying to generate proper hash for cpu_instrs.gb
@alloncm alloncm added refactor Improve the implementation bug Something isn't working labels Sep 23, 2024
@alloncm alloncm added the dependencies Pull requests that update a dependency file label Sep 23, 2024
@alloncm
Copy link
Owner Author

alloncm commented Sep 23, 2024

Need to test against the ili9341 driver

@alloncm alloncm merged commit cb8001a into master Oct 9, 2024
1 check passed
@alloncm alloncm deleted the deprecate branch October 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file refactor Improve the implementation
Projects
None yet
Milestone
No milestone
1 participant
@alloncm