fix: allow non-boolean v values for PrimitiveSignature #832
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/fix-deserialize
branch
from
c7cac54 to
ca04bf7
Compare
mattsse
approved these changes
Dec 26, 2024
unless the yParity field is supposed to be y-Parity but still allows values > 1 -.- |
|
yeah but hopefully this can only happen for 7702 authorizations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #831
This still does not allow non-boolean values for
yParitywhich should be fine I believeSolution
PR Checklist