[wip]: BlockExecutor
#1
Conversation
klkvr
force-pushed
the
klkvr/wip-executor
branch
from
2184951 to
5540708
Compare
klkvr
force-pushed
the
klkvr/wip-executor
branch
from
5540708 to
8a9da44
Compare
| EvmF: EvmFactory<Evm: Evm<Tx: From<T>>>, | ||
| ReceiptB: ReceiptBuilder<T, <EvmF::Evm as Evm>::Outcome>, | ||
| { | ||
| type Input = alloy_consensus::Block<T>; |
There was a problem hiding this comment.
we should perhaps consider adding some convenience type here so that we can accept any block variant, e.g. with recovered senders.
or we require it recovered as input
There was a problem hiding this comment.
Think API wise you want the block to be either type, and if it's not recovered it should do the recovery for you -- so probably a T: Into RecoveredBlock?
|
|
||
| impl<EvmF, ReceiptB, T> BlockExecutor for EthBlockExecutor<EvmF, ReceiptB, T> | ||
| where | ||
| EvmF: EvmFactory<Evm: Evm<Tx: From<T>>>, |
There was a problem hiding this comment.
this could be problematic where tx is like TxEnvelope because we still need to do recovery
| pub trait BlockExecutor { | ||
| /// Input for the block execution. | ||
| type Input: BlockExecutionInput; | ||
|
|
||
| /// Outcome of the block execution. | ||
| type Output: BlockExecutionOutcome; | ||
|
|
||
| /// Errors that can occur during block execution. | ||
| type Error; | ||
|
|
||
| fn execute(&mut self, input: Self::Input) -> Result<Self::Output, Self::Error>; | ||
| } |
There was a problem hiding this comment.
cool, yep I think this is it.
pretty simple and should allow for any kind of restrictions that may be necessary
| } | ||
| } | ||
|
|
||
| impl<T> BlockExecutionInput for alloy_consensus::Block<T> { |
There was a problem hiding this comment.
Note: this should still support somebody adding a custom block executor, say, enforcing inclusion lists from the header
Motivation
Solution
PR Checklist