Allow users to deposit raw ETH instead of just WETH #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aloe-prime canceled.
|
✅ Deploy Preview for aloe-blend-staging canceled.
|
✅ Deploy Preview for aloe-earn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IanWoodard
approved these changes
Apr 13, 2024
Comment on lines
+310
to
+311
| if (tokenBalanceResult != null) { | ||
| setInputValue(userBalance.toString(GNFormat.DECIMAL)); |
There was a problem hiding this comment.
While I see why it was done this way, I wish we could avoid having seemingly unrelated variables used in the if statement (despite them being quite related in actuality).
There was a problem hiding this comment.
Hmm good point. This was actually just a result of refactoring; I didn't write the code, but now that you point it out it is kinda bad/confusing. Any suggestions to fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.