-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devices for app store screenshots #124
base: master
Are you sure you want to change the base?
Add devices for app store screenshots #124
Conversation
@nfriend You can use something like this
in |
Yeah, it works devices.dart
screenshot.dart
main.dart
|
@pandazed Sorry, I'm a little confused. What are your comments above about? This is a proposal to add some new device frames to this repo 🤔 |
You can set any device you need in my example in No need to change something in |
This PR would be very nice to have. I am trying to produce App Store screenShots and I am missing:
|
What does this PR do?
Adds 6 new devices that allow developers to take screenshots that conform to all the size and resolution requirements of the iOS and Android app stores:
Notes
The devices do not have any frames, since they only exist for screenshotting purposes. I used these devices to capture all the screenshots for my Flutter app and can confirm it produces the correct sizes/aspect ratios for both stores.
If you don't like the lack of frames, I could consider surrounding each with a generic black square (maybe with some text describing its purpose), if that would make sense.
I'm also open to any naming changes if you think these could be more clear. Ideally, I would have put all of these devices in their own category/tab (e.g. "App store screenshots"), but it appears the current categories are backed by a built-in enum, so I wasn't sure how to go about this.
Compliments
Thanks so much for putting this project together! It literally saved me hours. My app is a drawing app, so putting together a single screenshot-worthy drawing can take hours. Doing this 5 times for each screenshot was a total non-starter for me.
Also, the way this project uses the SVG files as input is brilliant!
Closes #38
Closes #85