Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iphone 12 ratio changed #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

iphone 12 ratio changed #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion device_frame/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 30
compileSdkVersion 31
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is about the iPhone 12 ratio. Please exclude unrelated changes such as this one.


compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand Down
2 changes: 1 addition & 1 deletion device_frame/example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
buildscript {
ext.kotlin_version = '1.3.50'
ext.kotlin_version = '1.6.10'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is about the iPhone 12 ratio. Please exclude unrelated changes such as this one.

repositories {
google()
mavenCentral()
Expand Down
16 changes: 8 additions & 8 deletions device_frame/lib/src/devices/ios/iphone_12/device.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ final info = DeviceInfo(
'iphone-12',
),
name: 'iPhone 12',
pixelRatio: 2.0,
pixelRatio: 3.0,
frameSize: const Size(873.0, 1771.0),
screenSize: const Size(1024.0, 1366.0),
screenSize: const Size(390.0, 844.0),
safeAreas: const EdgeInsets.only(
left: 0.0,
top: 24.0,
top: 44.0,
right: 0.0,
bottom: 20.0,
bottom: 34.0,
),
rotatedSafeAreas: const EdgeInsets.only(
left: 0.0,
top: 24.0,
right: 0.0,
bottom: 20.0,
left: 44.0,
top: 0.0,
right: 44.0,
bottom: 21.0,
),
framePainter: const _FramePainter(),
screenPath: _screenPath,
Expand Down